Conversation
3da8382 to
fb51b66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Related: #7 ALFI-lib/alfi-lib.github.io/pull/3 ALFI-lib/alfi-lib.github.io/pull/8
Description
Refactor:
merge_coeffsfunction and replaced it with a loop.dXanddYfromconst Container<Number>toconst auto.Feature:
tridiag_solve_unstablefunction for use in cases where stability conditions are satisfied.tridiag_solvefunction based on Add not-a-knot boundary conditions snsinfu/cxx-spline#2.tridiag_solveis now used to compute coefficients for all splines, except for "Periodic", "Not-a-knot-start", "Not-a-knot-end" and "Semi-not-a-knot".It is used directly in "Not-a-knot", "Clamped", "Fixed-second" and "Fixed-third" and indirectly in "Natural" and "Parabolic-ends".
Documentation:
tridiag_solve_unstableandtridiag_solve.Licensing:
BSL-1.0license I had to place it somewhere in the repository. I put it inlicenses/BSL-1.0and added new fileLICENSEwhere the temporary "default copyright law" license is stated for clarity.